Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • pyddg pyddg
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 190
    • Issues 190
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 8
    • Merge requests 8
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • pyddg
  • pyddgpyddg
  • Merge requests
  • !548

Fail CI if flake8 checks fail

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Le Nam Do requested to merge fail-ci-if-flake8-checks-fail into develop May 26, 2023
  • Overview 15
  • Commits 26
  • Pipelines 7
  • Changes 88

...and fix most of the boring and hopefully uncontroversial errors and warnings. We have many unused variables and even undefined variables and various other issues that are ignored in .flake8 but those generally require more insight to fix quickly. For example, there are a bunch of unused variables in tests and I can't tell if they were supposed to be used for forgotten tests or something.

I found autoflake8 useful:

autoflake8 --keep-pass-statements --in-place --expand-star-imports -r .
autoflake8 --keep-pass-statements --in-place --remove-unused-variables  -r .

Requesting review from @blume since you care about at least some of these errors and warnings based on your reviews. It probably makes sense to look through the commits one by one.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fail-ci-if-flake8-checks-fail