Skip to content
GitLab
    • Explore Projects Groups Topics Snippets
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • pyddg pyddg
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 190
    • Issues 190
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 11
    • Merge requests 11
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • pyddg
  • pyddgpyddg
  • Merge requests
  • !547
An error occurred while retrieving approval data for this merge request.

Rewrite connected_components and intersection_curve

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Le Nam Do requested to merge rewrite-connected-components-intersection-curve into develop 2 years ago
  • Overview 16
  • Commits 8
  • Pipelines 6
  • Changes 4

Builds on !511 (merged) and !531 (merged) . Reviewers should probably just look at the individual commits starting at 02c0abdd2304f65ca1d1c2979da76b3a7b0a2661.

Fixes #611 (closed) #610 (closed) .

Edited 2 years ago by Le Nam Do
Pipeline #5064 passed for 52e561a3 on rewrite-connected-components-intersection-curve 1 year ago
Checking approval status

Merged by Jan TechterJan Techter 1 year ago (Sep 11, 2023 12:09pm UTC) 1 year ago

Loading

Activity


  • Le Nam Do requested review from @hoekstra 2 years ago

    requested review from @hoekstra

  • Le Nam Do changed the description 2 years ago

    changed the description

  • Le Nam Do changed the description 2 years ago

    changed the description

  • Le Nam Do mentioned in merge request !531 (merged) 2 years ago

    mentioned in merge request !531 (merged)

    • Aard Hoekstra
      Aard Hoekstra @hoekstra · 2 years ago
      Developer
      Resolved 1 year ago by Aard Hoekstra

      from the commit notes "this does mean that intersecting two objects with equal meshes results in <bpy_struct, Object invalid> though"

      this return value would appear not only when the meshes are equal but also when the two meshes have only overlapping intersections,

      for example two cubes where one is shifted over slightly in one axis image

      (in wire frame view)

      im not sure what the intended/expected behavior here should be (it is called intersect curve and not intersect mesh after all). However, if it stays like this, the possibility that the function returns <bpy_struct, Object invalid> should at least be mentioned somewhere in the docstring before someone thinks its a bug.

      Edited 2 years ago by Aard Hoekstra
    • Le Nam Do Aard Hoekstra Last reply by Le Nam Do 1 year ago
  • Le Nam Do added 1 commit 2 years ago

    added 1 commit

    • fedc8e71 - fix(blender): Be smarter about deleting mesh in intersection_curve

    Compare with previous version

  • Le Nam Do added 1 commit 2 years ago

    added 1 commit

    • b2e8e401 - fix(blender): Be smarter about deleting mesh in intersection_curve

    Compare with previous version

  • Le Nam Do mentioned in merge request !556 (merged) 2 years ago

    mentioned in merge request !556 (merged)

  • Le Nam Do mentioned in issue #520 2 years ago

    mentioned in issue #520

  • Le Nam Do added 108 commits 2 years ago

    added 108 commits

    • b2e8e401...2d5db7f2 - 107 commits from branch develop
    • c2458d08 - Merge branch 'develop' into 'rewrite-connected-components-intersection-curve'

    Compare with previous version

  • Le Nam Do
    Le Nam Do @do · 2 years ago
    Author Developer

    Attempted to resolve merge conflicts, but there are more issues besides the merge conflict...

    Edited 2 years ago by Le Nam Do
  • Le Nam Do added 28 commits 2 years ago

    added 28 commits

    • dbfd89bb - fix(docs): Add missing space before colon
    • 6df1fc6d - fix(docs): Fix typo
    • f995e6b4 - fix(docs): Fix typo
    • e8576031 - fix(docs): Add missing indentation
    • 9dc2a84d - refactor(docs): Improve Parameters section
    • abdeb528 - refactor(docs): Add full path to parameter
    • baac4272 - refactor(tests): Remove star import
    • 4666000e - feature(blender): Add get_data function
    • 3454e0ab - refactor(blender)!: Rename parameter for consistency
    • b964f04e - refactor(blender)!: Throw an exception in shade_smooth for curves
    • f681260a - fix(docs): Add missing parameter description
    • 4af844e0 - refactor(blender)!: Remove parent and matrix parameters from join
    • 07a74a64 - fix(tests): Add clear_meshes fixture
    • d29937b7 - refactor(blender)!: Rewrite mesh join function
    • 9b233c69 - refactor(docs): Remove redundant word
    • 3487bb21 - refactor(blender): Improve formatting in error message
    • a4503e9e - refactor(blender): Make mesh transform work for objects too
    • 211768c5 - fix(docs): Fix default value formatting
    • 4090210a - docs(blender): Specify when objects must have mesh data
    • 015d95ce - refactor(blender)!: Make mesh transform return the input
    • 66962493 - refactor(blender)!: Rename get_data parameter to x
    • 792bb8fe - fix(blender): If not keep_original, delete meshes in mesh.join
    • 2b2f2f4e - feat(blender): Make mesh.connected_components more robust
    • 1578edfb - tests(blender): Clear curves before and after each test
    • 5a09bbff - feat(blender)!: Make mesh.intersection_curve more general and robust
    • 77ac209c - fix(blender): Be smarter about deleting mesh in intersection_curve
    • 943681c0 - refactor(blender)!: Rename intersection_curve to intersection
    • d6641671 - refactor(blender): Handle 2D intersections in mesh.intersection

    Compare with previous version

    Toggle commit list
  • Le Nam Do
    Le Nam Do @do · 2 years ago
    Author Developer

    Rebased on !531 (merged).

    d6641671 also handles 2-dimensional intersections.

  • Aard Hoekstra
    Aard Hoekstra @hoekstra started a thread on commit 5a09bbff 2 years ago
    Resolved 2 years ago by Le Nam Do
  • Le Nam Do added 105 commits 1 year ago

    added 105 commits

    • d6641671...192a7bf4 - 97 commits from branch develop
    • 1f2b2ac9 - fix(blender): If not keep_original, delete meshes in mesh.join
    • 0250ce49 - feat(blender): Make mesh.connected_components more robust
    • e04bf5c7 - tests(blender): Clear curves before and after each test
    • ca01a0df - feat(blender)!: Make mesh.intersection_curve more general and robust
    • a507276e - fix(blender): Be smarter about deleting mesh in intersection_curve
    • 803981f4 - refactor(blender)!: Rename intersection_curve to intersection
    • 24ee0440 - refactor(blender): Handle 2D intersections in mesh.intersection
    • 52e561a3 - docs(blender): Explain that mesh intersections aren't reliable

    Compare with previous version

    Toggle commit list
    • Le Nam Do
      Le Nam Do @do · 1 year ago
      Author Developer
      Resolved 1 year ago by Aard Hoekstra

      Resolved merge conflicts and added a little warning to intersection's docstring. @hoekstra , could you take another look at this? Thanks.

      I don't think it's possible to fix the 2d intersection issues given that we rely completely on Blender's intersection operators. They don't even handle the 1d case reliably after all. Since intersection is barely used anyway, I'd rather move this along and get it merged, if we need better mesh intersections in the future, we can revisit.

    • Aard Hoekstra Le Nam Do Last reply by Le Nam Do 1 year ago
  • Le Nam Do mentioned in merge request !577 (merged) 1 year ago

    mentioned in merge request !577 (merged)

  • Aard Hoekstra marked this merge request as ready 1 year ago

    marked this merge request as ready

  • Aard Hoekstra approved this merge request 1 year ago

    approved this merge request

  • Aard Hoekstra resolved all threads 1 year ago

    resolved all threads

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Assignee
Jan Techter's avatar
Jan Techter
Assign to
0 Reviewers
Request review from
Labels
0
None
0
None
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
Lock merge request
Unlocked
Participants
Reference:
Source branch: rewrite-connected-components-intersection-curve

Menu

Explore Projects Groups Topics Snippets