Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • pyddg pyddg
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 190
    • Issues 190
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 8
    • Merge requests 8
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • pyddg
  • pyddgpyddg
  • Merge requests
  • !440

Clean up ddg.math.symmetric_matrices

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Leander Blume requested to merge clean_up_ddg.math.symmetric_matrices into develop Oct 17, 2022
  • Overview 5
  • Commits 7
  • Pipelines 4
  • Changes 2

Contributes to #518.

I just cleaned some smaller things up and improved the documentation. But some questions remain:

  • At some point, there was the idea to move the Signature classes somewhere else, for example to the ddg.geometry.quadrics module. That particular module is not the best place imo, because the signature classes don't depend on quadrics in any way, only the other way around. But I still think we might want to move them in the future.
  • The module mixes functionality for raw symmetric matrices and "projective" functionality for symmetric matrices up to nonzero scalar multiplication. We might want to separate this more clearly.

Both of these are tasks for the future imo.

Edited Oct 18, 2022 by Leander Blume
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: clean_up_ddg.math.symmetric_matrices