Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • pyddg pyddg
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 190
    • Issues 190
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 8
    • Merge requests 8
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • pyddg
  • pyddgpyddg
  • Merge requests
  • !389

restructure(math)!: Rename ddg.math.functools to ddg.math._functools

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Le Nam Do requested to merge hide-our-functools into develop Sep 13, 2022
  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 2

Prepending the module name with an underscore should be sufficient to discourage downstream from using this module.

Commit message below:

This module only contains the "compose" function, which is only used in ddg.abc.Transformable. Since the latter will get removed anyway, this module shouldn't be exposed to the public in its current form, since

  • "compose" doesn't correctly handle compositions including functions with multiple arguments,
  • "compose" is never strictly speaking necessary and
  • a functools module probably shouldn't live in ddg.math.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: hide-our-functools